Skip to content

Implment matches domain - #78

Merged
rootandroo merged 0 commit into
add-match-cycles-domainfrom
add-matches-domain
Aug 24, 2026
Merged

Implment matches domain#78
rootandroo merged 0 commit into
add-match-cycles-domainfrom
add-matches-domain

Conversation

@rootandroo

@rootandroo rootandroo commented Aug 14, 2026

Copy link
Copy Markdown
Contributor
  • create controller for creating a match between two members
  • create service for an admin to create a match between two members
  • create DTOs for responses and requests

@rootandroo rootandroo mentioned this pull request Aug 14, 2026
Open
@rootandroo Graphite App

rootandroo commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rootandroo rootandroo mentioned this pull request Aug 14, 2026
Merged
@rootandroo
rootandroo force-pushed the add-matches-domain branch 2 times, most recently from 63b3fe2 to b09b563 Compare August 14, 2026 19:42
@sonarqubecloud

sonarqubecloud Bot commented Aug 14, 2026

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@rootandroo
rootandroo force-pushed the api-match-repos branch 2 times, most recently from 3df3274 to b63a2c8 Compare August 14, 2026 21:00
arklian
arklian requested changes Aug 14, 2026
View reviewed changes
Comment thread src/main/java/org/patinanetwork/patchats/api/match/AdminMatchController.java

@arklian arklian Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just stick with MatchController for everything, and then we can handle the permissioning after the fact, once Randy's done.

Comment thread src/main/java/org/patinanetwork/patchats/api/match/dto/cycle/CreateMatchCycleRequest.java Outdated

@arklian arklian Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep requests and response names synced, even if you have to repeat them.

I know it's kinda annoying and verbose, but it should be ->
CreateMatchCycleRequest
CreateMatchCycleResponse

I personally like having protobuf files to condense all of these DTOs into one file, but that's more infra to set up.

Comment thread src/main/java/org/patinanetwork/patchats/api/match/dto/match/UpdateMatchFeedbackRequest.java Outdated

@arklian arklian Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets drop everything related to feedback.

@rootandroo
rootandroo force-pushed the add-matches-domain branch 2 times, most recently from 9a8e12b to 51b519f Compare August 17, 2026 17:30
@sonarqubecloud

sonarqubecloud Bot commented Aug 17, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rootandroo rootandroo mentioned this pull request Aug 17, 2026
Open
@rootandroo
rootandroo changed the base branch from api-match-repos to graphite-base/78 August 17, 2026 19:42
@rootandroo
rootandroo changed the base branch from graphite-base/78 to add-match-cycles-domain August 17, 2026 19:42
@rootandroo rootandroo mentioned this pull request Aug 17, 2026
Closed
@sonarqubecloud

sonarqubecloud Bot commented Aug 17, 2026

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@rootandroo rootandroo changed the title Implement create match between two members for a match cycle Implment matches domain Aug 19, 2026
@rootandroo
rootandroo force-pushed the add-match-cycles-domain branch from 0c6a612 to 9088e15 Compare August 24, 2026 16:29
@rootandroo
rootandroo force-pushed the add-match-cycles-domain branch from 9088e15 to ba16103 Compare August 24, 2026 17:05
@rootandroo rootandroo closed this Aug 24, 2026
@rootandroo
rootandroo merged commit cff17cb into add-match-cycles-domain Aug 24, 2026
@rootandroo
rootandroo force-pushed the add-match-cycles-domain branch from ba16103 to 59a3e5f Compare August 24, 2026 17:29
@rootandroo
rootandroo deleted the add-matches-domain branch August 24, 2026 17:29
@sonarqubecloud

sonarqubecloud Bot commented Aug 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rootandroo
rootandroo restored the add-matches-domain branch August 24, 2026 17:30
@rootandroo
rootandroo deleted the add-matches-domain branch August 24, 2026 17:59
@rootandroo Graphite App

rootandroo commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

Merging into #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arklian arklian arklian requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rootandroo @arklian