Add breakdowns to the build side bar on mouseover - #10196
Conversation
|
The underlines do make it look a tad busy. Would making the calc specific numbers/terms bolder work here? Other option could be to keep the underline just for the keywords? |
|
Also agree the underlines are a little busy. Would it be possible/better if they were dashed like in poe2? Or maybe just the numbers and not the text, or the text but not the numbers. |
I removed the left side underlines and made it slightly darker. Clickbox is still the same, but I think this is a bit cleaner? |
vaisest
added
enhancement
|
What do you think of something like this? |
We came to sort of a conclusion on Discord (if you're not there as a contributor, ask local) that it's probably best to keep the underlining for a short period and then we can remove it completely once users are more familiar with it |
|
Ah, gotcha. No worries. @LocalIdentity can I get an invite to the discord if possible? |
--- New to Path of Building --- * Add support for pseudo stats in trader (vaisest) --- Fixed Crashes --- * Fix crash when double-clicking and dragging an item on small window sizes (vaisest) * Fix crash from equipping Quivers and Shields that grant skills (LocalIdentity) --- Fixed Calculations --- * Fix Chip Away not using a global limit (Trifall) * Fix Foulgrasp support not increasing Brand limit (Trifall) * Fix Block chance rounding with Mana-Infused Staff (LocalIdentity) --- Fixed Behaviours --- * Fix harvest Weapon Range enchant not appearing properly (vaisest) * Fix "Buy Similar" searches for punctuated unique names (mcagnion) * Fix missing modifier controls on imported items (vaisest) * Fix file sort not using folder name when determining the sort order of builds (xoxorwr) * Prevent recursion from stopping on file errors in build list (xoxorwr)
…ngCommunity#10158) * Fixes PathOfBuildingCommunity#10157: Fix Scornful Herald not counting buffs as affecting you * Simpler fix of making it have 100% less buff effect Made it use less buff effect instead so it would show up in a breakdown if we made one in the future --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
* Prepare release 2.67.2 * Changelog --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
--- Fixed Calculations --- * Fix Scornful Herald not counting buffs as affecting you (Wires77) * Fix The Unblinking Eye increased evasion not applying to Attacks with Arcane Might (andyli00) --- Fixed Behaviours --- * Fix Foulborn icon display on Linux (cupkax) * Fix double-clicking and dragging items causing issues (vaisest)
5 participants
Description of the problem being solved:
This adds the calc tab breakdowns to the build side bar. This is sort of inspired by poe.ninja.
The breakdowns seem to work quite well, but I think this looks quite busy, and I'll welcome opinions on whether or not this needs visual changes or not.Feedback received. I toned down the underlining a bit. Optimally I think we should remove this later, but it's good to have now to teach users that this actually exists. TPlant also mentioned a small diamond icon. It doesn't seem like something PoB or PoE has used before, but that could work too.I also don't have perfect knowledge on what all the calcs stuff means. For example I have no clue what omniscience is, or why the off-hand breakdowns would be relevant.
The breakdowns are indexed based on their names from
CalcSections, and in most cases theBuildDisplayStatsstat names are used to look up the breakdown. This is not always possible and thus I added abreakdown string?field to the display stats to force a breakdown if e.g. the name is different. There's also amodNames string[]?field for defining mod lists if, for example, the breakdown doesn't have any mod lists in the cell (e.g. Life). These exceptions have to be manually fixed.One problem with this approach is that if multiple cells have the same breakdown, we might get a bad match, like what happens with armour/ev/es. For these it's better to just ignore the breakdown and to add modnames manually.
I have fixed most stat displays, and made sure that minions work. One issue was that the main env doesn't contain breakdowns. This was fixed by generating them for the main env, and I'm not sure how bad that is. I'd assume the breakdowns were restricted to "CALCS" for a reason.
Pinning is supported (not the popup but like left clicking a cell).
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Minions: https://poe.ninja/poe1/pob/96cb6
Totems: https://poe.ninja/poe1/pob/96cb7
Mamba: https://poe.ninja/poe1/pob/96cb9
Worb: https://poe.ninja/poe1/pob/96cba
Before screenshot:
After screenshot:
Path.space.of.space.Building_2026-08-11_19-12-42.mp4