Regression tests: Fixing interpolation to match v3 - #2812
Open
erikvansebille wants to merge 5 commits into
Open
Regression tests: Fixing interpolation to match v3 #2812erikvansebille wants to merge 5 commits into
erikvansebille wants to merge 5 commits into
Conversation
This matters for C-grid interpolation, which is non-continuous
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some fixes to v4 so that the regression tests of all four interpolation schemes tested in v3 pass. Note that I had to add a "NearestNeighbour Velocity" interpolation; but since I don't see any use-cases for it I put it in the tests directory instead of _xinterpolators
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None