Skip to content

Fixes missassignment of n_faces and n_nodes in fesom_to_ugrid - #2810

Merged
wyatt-fluidnumerics merged 2 commits into
mainfrom
fix-nod2-elem-mismatch-in-fesom-to-ugrid
Aug 12, 2026
Merged

Fixes missassignment of n_faces and n_nodes in fesom_to_ugrid#2810
wyatt-fluidnumerics merged 2 commits into
mainfrom
fix-nod2-elem-mismatch-in-fesom-to-ugrid

Conversation

@wyatt-fluidnumerics

@wyatt-fluidnumerics wyatt-fluidnumerics commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

Previously, there was a bug in fesom_to_ugrid which mismatched the assignment of n_node and n_face. This PR resolves this issue thereby fixing downstream IndexSearch errors that occur during interpolation.

Checklist

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.
    • Describe how you used it (e.g., by pasting your prompt): This bug was originally found by claude while working on a local copy of the parcels-benchmarks repo. I then verified it and provided the fix myself.

@VeckoTheGecko

Copy link
Copy Markdown
Contributor

Thanks for the PR @wyatt-fluidnumerics . I think that this looks good, but will leave it up to you or @fluidnumericsJoe for the final say.

Quick pulsecheck - do you have merge access already?

@wyatt-fluidnumerics

wyatt-fluidnumerics commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Sounds good, I do have merge access already!

@erikvansebille erikvansebille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wyatt-fluidnumerics
wyatt-fluidnumerics enabled auto-merge (squash) August 12, 2026 13:23
@wyatt-fluidnumerics
wyatt-fluidnumerics merged commit c9ccd66 into main Aug 12, 2026
17 of 18 checks passed
@wyatt-fluidnumerics
wyatt-fluidnumerics deleted the fix-nod2-elem-mismatch-in-fesom-to-ugrid branch August 12, 2026 14:57
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Parcels development Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug in assignment of faces vs nodes in fesom_to_ugrid()

3 participants