Fixes missassignment of n_faces and n_nodes in fesom_to_ugrid - #2810
Merged
wyatt-fluidnumerics merged 2 commits intoAug 12, 2026
Conversation
…nd elem->n_faces respectively
Contributor
|
Thanks for the PR @wyatt-fluidnumerics . I think that this looks good, but will leave it up to you or @fluidnumericsJoe for the final say. Quick pulsecheck - do you have merge access already? |
Contributor
Author
|
Sounds good, I do have merge access already! |
wyatt-fluidnumerics
enabled auto-merge (squash)
August 12, 2026 13:23
wyatt-fluidnumerics
deleted the
fix-nod2-elem-mismatch-in-fesom-to-ugrid
branch
August 12, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, there was a bug in
fesom_to_ugridwhich mismatched the assignment ofn_nodeandn_face. This PR resolves this issue thereby fixing downstreamIndexSearcherrors that occur during interpolation.Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure