[XPU] Fix PaddleFormers fallback model issues - #8116
Open
mayang002 wants to merge 2 commits into
Open
Conversation
- Fix TypeError when calling the PaddleFormers fallback model - Do not rotate twice when the model already applied RoPE - Fix position_ids for the adjust_batch token layout
- Move _get_identity_rotary_embs to the AttentionBackend base class with layout-adaptive indexing (fixes the multimodal [batch, 2, ...] layout) - Replace the inline identity RoPE block in XPUAttentionBackend with the base class method; drop the duplicated copies in append_attn_backend and decode_unified_attention_backend - Add None guards for optional LOD fields in _build_position_ids_from_lods - Add docstrings to the new test methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes three issues hit when using the PaddleFormers fallback path on XPU:
TypeErrorwhen calling the PaddleFormers fallback model (fastdeploy/model_executor/models/paddleformers/__init__.py)position_idsfor theadjust_batchtoken layout (paddleformers/base.py)Testing
tests/model_executor/test_paddleformers_base.pycovering theadjust_batchposition_ids layout