[v1 loader UT]add v1 loader unitest - #3520
Closed
bukejiyu wants to merge 1 commit into
Closed
Conversation
|
Thanks for your contribution! |
YuanRisheng
reviewed
Aug 21, 2025
| @@ -0,0 +1,125 @@ | |||
| # Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved. | |||
Collaborator
There was a problem hiding this comment.
文件命名里把v1这种字段去掉吧，因为这个中间状态存在时间较短，后续切换后就没有v1了，而且我们旧Loader本身也没单测，另外我建议可以新建一个model_loader的目录，把这个文件挪过去，后续loader的单测都写到这个目录下
| @@ -0,0 +1,92 @@ | |||
| # Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved. | |||
| @@ -0,0 +1,89 @@ | |||
| # Copyright (c) 2025 PaddlePaddle Authors. All Rights Reserved. | |||
Collaborator
There was a problem hiding this comment.
注意当前由于qa重命名的问题，我们应该把所有单测放到tests目录下，而非test目录，后续qa会修改目录名
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.