fix: correct p-adic digit ordering in Extended Monna Mapping digit display - #108
Open
iislucas wants to merge 1 commit into
Open
fix: correct p-adic digit ordering in Extended Monna Mapping digit display#108iislucas wants to merge 1 commit into
iislucas wants to merge 1 commit into
Conversation
…splay - Update currentRationalCenter in BerkovichEncodingComponent to compute p-adic digits matching tree leaf representations\n- Update onDigitDisplayCenterChange to map edited p-adic digits back to real target values\n- Update bluePinVal in BerkovichEncodingTreeVisComponent to consistently use decoded target values\n- Update unit tests in berkovich-encoding.component.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
BerkovichEncodingComponent,currentRationalCenternow computes the 569Xadic center rational whose digits inBerkovichDigitDisplayComponentmatch the leaf node 569Xadic representation (e.g. = 0.6875$ with binary path 1$ now renders 569Xadic digits[ 1 ] [ 1 ] [ 0 ] [ 1 ], matching leaf label1101₂on the tree).onDigitDisplayCenterChange, edits made in the digit display are properly converted from the 569Xadic digit sequence back to the real number target \in [0, 1]$.BerkovichEncodingTreeVisComponent,bluePinValconsistently uses the decoded target value on the 1$ number line.berkovich-encoding.component.spec.ts.