Remove stray debug print statements from the SDK - #34
Open
pucedoteth wants to merge 1 commit into
Open
pucedoteth wants to merge 1 commit into
pucedoteth wants to merge 1 commit into
Conversation
Two library functions print to stdout on every call: - `request_pnl_settlement` prints the full EIP-712 settlement message (broker, chain, nonce, user address, timestamp) before signing it. - `get_referral_rebate_summary` prints its start/end date arguments. Both are leftover debugging output. A library should not write to stdout, and the settlement one leaks the structured message a caller is about to sign into the application's logs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two REST helpers write to stdout on every call:
request_pnl_settlement(_settlement.py) callsprint(message)on the full EIP-712 settlement message — broker id, chain id, settle nonce, user address, timestamp — right before signing it.get_referral_rebate_summary(_referral.py) callsprint(start_date, end_date)on its arguments.Why it matters
Both are leftover debugging output. A connector library shouldn't print to the host application's stdout, and the settlement one dumps the structured payload the caller is about to sign into their logs. After the change,
orderly_evm_connector/contains noprint()calls.No behavior changes beyond removing the two lines; both modules still compile.