Skip to content

rtd: fix the waitForTargeting event and fold in the wrappers' control-group and cache gates - #338

Open
etiennelatendresse-optable wants to merge 2 commits into
masterfrom
rtd-control-group-cache-first
Open

rtd: fix the waitForTargeting event and fold in the wrappers' control-group and cache gates#338
etiennelatendresse-optable wants to merge 2 commits into
masterfrom
rtd-control-group-cache-first

Conversation

@etiennelatendresse-optable

@etiennelatendresse-optable etiennelatendresse-optable commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

waitForTargeting currrently waits for optableResolved which nothings dispatches so the wait always time out. The wait would also leak a listener on timeout.

What Changed

  • waitForTargeting now listens for optable-targeting:change
  • New isControlGroup?: () => boolean option checked per auction in handleRtd. While true, serves no EIDs
  • The wait now triggers when the cache has no EIDs, not just when the cache key is absent
  • Add new tests
  • Add doc

How to Test

  • Tested
  • Docs updated

Notes

  • Breaking change
  • Requires release

@etiennelatendresse-optable etiennelatendresse-optable changed the title Rtd control group cache first rtd: fix the waitForTargeting event and fold in the wrappers' control-group and cache gates Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nelson-optable Nelson-optable Awaiting requested review from Nelson-optable Nelson-optable is a code owner automatically assigned from Optable/solutions

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@etiennelatendresse-optable