Harden multiplayer networking and adapt frame timing - #83
Open
ZivDero wants to merge 14 commits into
Open
Conversation
ZivDero
marked this pull request as ready for review
August 30, 2026 23:25
|
Development builds of 4230f5a: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks thbe networking:
Hardens network packet handling
Defended against too small, too large packets, malformed packets, unknown packets.
Also covers the entire abuse set of sending packets as another player's house, so now the only way to cheat here is to fake stuff on the actual network transport layer.
Improve connection-level timing
Partly based on Add fast retransmit of lost packets and packet redundancy CnCNet/yrpp-spawner#75
Improves actual connection timing to better reflect connection quality on a per-connection basis to not stall everyone unnecessarily.
Improve lockstep timing
An evolution of "protocol zero", improving the selection of FrameSendRate and MaxAhead based on the connection quality.
Includes downgrading for bad connections and limited upgrading (to prevent ping-pong when connection quality varies).
Closes #21, closes #22, closes #23, closes #24, closes #25, closes #26, closes #35