Translate sos adpcm codecs from ASM to C++ - #82
Closed
tinix0 wants to merge 4 commits into
Closed
Conversation
No documentation update: tests/sosparity checks the C++ codec against golden vectors recorded from the original assembly, so documented audio behavior is unchanged.
tests/sosparity tested the retired VQA_sosCODEC*/General_sosCODEC* functions directly and no longer builds against the merged API; removed with no replacement, so the decoder currently has no automated regression coverage.
|
Development builds of c6572b6: The links work without a GitHub account. Artifacts expire after 90 days, and this comment follows the latest successful build. |
tinix0
force-pushed
the
translate-sos-adpcm-codecs
branch
from
August 30, 2026 17:02
aee4eab to
c6572b6
Compare
ZivDero
reviewed
Aug 30, 2026
Comment on lines
+14
to
+17
| #include "soscomp.h" | ||
| #include <string.h> | ||
| #include <assert.h> | ||
|
|
Member
There was a problem hiding this comment.
always.h should be included first, then the rest sorted per clang-format. And empty line after banner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of Vanilla-Conquer implementation of soscodec.cpp. Smoke tested in GDI1.