Skip to content

test: fix frame sizing and view graph test isolation - #1090

Merged
Kyle-Ye merged 1 commit into
mainfrom
test/flex-frame-safe-area
Sep 20, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
test/flex-frame-safe-area

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 20, 2026

Copy link
Copy Markdown
Member

Summary

  • Disable hosting safe area regions in the flex frame sizing test on iOS and visionOS so window insets do not change its expected size.
  • Run ViewGraphTests on the main actor to serialize access to shared view graph update state.

@github-actions github-actions Bot added area: layout Layout, geometry, safe area, alignment, stacks, or sizing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: tests Test coverage, test infrastructure, snapshots, or test-only changes. labels Sep 20, 2026
@tuist

tuist Bot commented Sep 20, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1241 0 1241 e0249eedc

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 39.6s e0249eedc

@codecov

codecov Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.11%. Comparing base (5af2b2b) to head (e14ca67).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   28.87%   33.11%   +4.24%     
==========================================
  Files         750      803      +53     
  Lines       55271    63659    +8388     
==========================================
+ Hits        15958    21081    +5123     
- Misses      39313    42578    +3265     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye force-pushed the test/flex-frame-safe-area branch from 122f2ec to e14ca67 Compare September 20, 2026 16:27
@Kyle-Ye Kyle-Ye changed the title test: isolate flex frame sizing from safe area insets test: fix frame sizing and view graph test isolation Sep 20, 2026
@github-actions github-actions Bot added the area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. label Sep 20, 2026
@Kyle-Ye
Kyle-Ye merged commit acc902c into main Sep 20, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the test/flex-frame-safe-area branch September 20, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. area: layout Layout, geometry, safe area, alignment, stacks, or sizing. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: tests Test coverage, test infrastructure, snapshots, or test-only changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant