Skip to content

feat: complete ViewGraph behavior - #1087

Merged
Kyle-Ye merged 1 commit into
mainfrom
feature/view_graph
Sep 19, 2026
Merged

Kyle-Ye merged 1 commit into
mainfrom
feature/view_graph

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Complete preference bridging, reuse notifications, and teardown cleanup in ViewGraph.
  • Implement safe-area measurement and alignment, rebuild graphs when requested outputs change, and return transformed display lists.
  • Preserve nested graph contexts and scheduling edge cases, with regression coverage for lifecycle, layout, and update requests.

@github-actions github-actions Bot added area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. area: layout Layout, geometry, safe area, alignment, stacks, or sizing. type: feature New API, behavior, platform support, or user-facing capability. labels Sep 19, 2026
@tuist

tuist Bot commented Sep 19, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1241 0 1241 9b40edebe

Failed Tests ❌

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 47.7s 9b40edebe

@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.90110% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 33.10%. Comparing base (cc24a30) to head (4a994b8).

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/View/Graph/ViewGraph.swift 98.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   32.57%   33.10%   +0.53%     
==========================================
  Files         803      803              
  Lines       63605    63661      +56     
==========================================
+ Hits        20721    21078     +357     
+ Misses      42884    42583     -301     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 5af2b2b into main Sep 19, 2026
5 of 6 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/view_graph branch September 19, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: graph ViewGraph, AttributeGraph, graph hosts, and graph internals. area: layout Layout, geometry, safe area, alignment, stacks, or sizing. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant