Skip to content

fix(gesture): prevent tap gesture crashes - #1080

Merged
Kyle-Ye merged 3 commits into
mainfrom
bugfix/gesture_phase
Sep 13, 2026
Merged

fix(gesture): prevent tap gesture crashes#1080
Kyle-Ye merged 3 commits into
mainfrom
bugfix/gesture_phase

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Preserve the gesture info attribute across child subgraph creation and access Map2Gesture's body through its key path.
  • Treat began events as active gestures so DurationPhase initializes elapsed time before release.
  • Correct event selection and convert raw coordinates before constructing output event values.
  • Add regression coverage for phase transitions, resets, event bindings, coordinate conversion, and begin/end duration handling.

@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. impact: crash Crash, assertion, or fatal runtime failure. type: bug Something is not working correctly. type: tests Test coverage, test infrastructure, snapshots, or test-only changes. labels Sep 13, 2026
@tuist

tuist Bot commented Sep 13, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1224 0 1224 4d8e30942

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 57.8s 4d8e30942

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.46%. Comparing base (57d410b) to head (362c38b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ces/OpenSwiftUICore/Event/Gesture/AnyGesture.swift 0.00% 3 Missing ⚠️
.../OpenSwiftUICore/Event/Gesture/EventListener.swift 94.11% 1 Missing ⚠️
...es/OpenSwiftUICore/Event/Gesture/Map2Gesture.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
+ Coverage   30.08%   30.46%   +0.37%     
==========================================
  Files         802      802              
  Lines       63538    63525      -13     
==========================================
+ Hits        19117    19351     +234     
+ Misses      44421    44174     -247     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit a321de1 into main Sep 13, 2026
5 of 6 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/gesture_phase branch September 13, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. impact: crash Crash, assertion, or fatal runtime failure. type: bug Something is not working correctly. type: tests Test coverage, test infrastructure, snapshots, or test-only changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant