Provide Foundations for 1024 - #1078
Closed
Nexushunter wants to merge 10 commits into
Closed
Conversation
Nexushunter
force-pushed
the
nh/issue-1024
branch
from
September 13, 2026 20:07
44158ac to
e8c2545
Compare
Author
|
FP (rebased) |
Nexushunter
marked this pull request as ready for review
September 13, 2026 20:30
Nexushunter
commented
Sep 13, 2026
Nexushunter
left a comment
Nexushunter
left a comment
Author
There was a problem hiding this comment.
Not 100% ready just need some recommendations on testing. Thanks in advance!
| } | ||
|
|
||
| var button = Button ("Run", cb) | ||
| // TODO: Trigger attempt to press button. |
Author
There was a problem hiding this comment.
I didn't see any examples for testing gestures. Some guidance would be appreciated 😄
Member
|
I already have a complete working impl on label and button. And I'm going to handle them next week. Just forgot to assign them to me. (Sorry) 
Also I suggest starter can first contribute to known bugs instead of new features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The SDK is in need of support for Buttons but an extension is blocked behind not having Label<Text,Icon>.
Solution
I started to implement #1024 (Button) and noticed I was going to need parts of #1023 to fully implement a Button. In an effort to not block #1024 (the original I issue wanted to address).
QA