Skip to content

feat(hosting): integrate hit-test handling and diagnostics - #1077

Merged
Kyle-Ye merged 1 commit into
mainfrom
feature/hosting_hittest
Sep 13, 2026
Merged

feat(hosting): integrate hit-test handling and diagnostics#1077
Kyle-Ye merged 1 commit into
mainfrom
feature/hosting_hittest

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Route UIKit gesture hit tests through hosting views while preserving hits on foreign subviews, and correct the Swift import of the current hit-test context.
  • Connect UIKit touch events and AppKit left mouse clicks to hit-test diagnostics while avoiding duplicate output from nested hosting views.
  • Register the AppKit event monitor when hit-test debugging is enabled and remove it when the hosting view is deinitialized.

Validation: Scoped UIKit type checking, four AppKit monitor lifecycle checks, Swift parsing, and whitespace checks passed.

@Kyle-Ye
Kyle-Ye requested a review from Mx-Iris as a code owner September 13, 2026 18:44
@github-actions github-actions Bot added area: event-gesture Events, gestures, tracing, or interaction plumbing. area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. type: feature New API, behavior, platform support, or user-facing capability. labels Sep 13, 2026
@tuist

tuist Bot commented Sep 13, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1198 0 1198 3bcc57b6d

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 1m 15s 3bcc57b6d

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.65%. Comparing base (24b736d) to head (d90f8c6).

Files with missing lines Patch % Lines
...ntegration/Hosting/AppKit/View/NSHostingView.swift 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   29.65%   29.65%   -0.01%     
==========================================
  Files         802      802              
  Lines       63274    63285      +11     
==========================================
+ Hits        18763    18764       +1     
- Misses      44511    44521      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 80d9c2b into main Sep 13, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/hosting_hittest branch September 13, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: event-gesture Events, gestures, tracing, or interaction plumbing. area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant