Skip to content

feat(hosting): track foreign subviews and report unsupported additions - #1076

Merged
Kyle-Ye merged 4 commits into
mainfrom
feature/hosting_hittest
Sep 13, 2026
Merged

feat(hosting): track foreign subviews and report unsupported additions#1076
Kyle-Ye merged 4 commits into
mainfrom
feature/hosting_hittest

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Track foreign subview additions and removals in UIKit and AppKit hosting views while excluding rendered content.
  • Report unsupported additions with v7 linked semantics, using the appropriate host name and cached internal-build detection for UIKit.
  • Share runtime-issue test support and add regression tests for didAddSubview on both platforms.

Validation: The focused UIKit and AppKit hosting-view tests each passed with one test and no failures.

@Kyle-Ye
Kyle-Ye requested a review from Mx-Iris as a code owner September 13, 2026 18:07
@github-actions github-actions Bot added area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability. labels Sep 13, 2026
@tuist

tuist Bot commented Sep 13, 2026

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
OpenSwiftUI 0 % 1198 0 1198 4a34b4fbb

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI 38.5s 4a34b4fbb

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 29.66%. Comparing base (06f828f) to head (c6a4b07).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ntegration/Hosting/AppKit/View/NSHostingView.swift 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
- Coverage   29.70%   29.66%   -0.04%     
==========================================
  Files         799      802       +3     
  Lines       63094    63274     +180     
==========================================
+ Hits        18741    18770      +29     
- Misses      44353    44504     +151     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Kyle-Ye merged commit 24b736d into main Sep 13, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the feature/hosting_hittest branch September 13, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: hosting-bridge SwiftUI bridge, UIHosting/NSHosting, representables, and platform host views. area: tests Test suites, UI tests, fixtures, snapshots, and test support code. type: feature New API, behavior, platform support, or user-facing capability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant