supported-mice: mark the Lamzu Inca 8K as PR-pending with its PIDs - #157
Draft
bpavlina wants to merge 1 commit into
Draft
supported-mice: mark the Lamzu Inca 8K as PR-pending with its PIDs#157bpavlina wants to merge 1 commit into
bpavlina wants to merge 1 commit into
Conversation
The Inca enumerates under Lamzu's own vendor id 0x37b0 rather than the shared CompX ODM id 0x373e that every other Lamzu, CRDRAKO and Attack Shark product uses, so the driver never saw it. The row's old note said only that a PID was missing from an existing driver, which understated it. Read-only support is now open upstream in mouse-protocol. The three product ids are pinned now: 0x0009 the mouse on its cable and 0x0010 the 8K receiver, both confirmed on hardware, and 0x000f the 1K receiver, which comes from the vendor's device table alone and has not been exercised. A "pr" row is exempt from the PID_UNIVERSE check, so this stays green against the currently published protocol; the flip to "supported", plus the matching PID_UNIVERSE entry, follows that merge. The row deliberately keeps the model name "Inca" rather than "Inca 8K". The live overlay matches request votes by brand and model, and its fuzzy matcher ignores single-word model names, so renaming this row would orphan the request count it already carries. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018C96pMdnhGcXhLQhHYkLWc
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to OpenMouse-Project/mouse-protocol#45, which adds the Lamzu Inca 8K under Lamzu's own vendor id
0x37b0.src/supported-mice.tscurrently carries the Inca asstatus: "quickwin"with the note "CompX protocol implemented; Inca PID not yet in driver". That understates it — the model was invisible to the driver because it enumerates under0x37b0rather than the shared CompX ODM id0x373e, not because a PID was missing from a catalog the driver already read. This updates the row and pins the three product ids.Why
"pr"and not"supported"PID_UNIVERSEinsupported-mice.test.tsis built from the registries that@openmouse/protocolexports, and the published package does not exportLAMZU_INCA_PRODUCTSyet. Marking the rowsupportedtherefore cannot even compile until mouse-protocol#45 lands. Aprrow is exempt from the pinned-PID check, which is exactly what that status is for, so this is green against the currently published protocol and can merge on its own.Once #45 is in and the dependency is bumped, the follow-up is two small edits together:
supported-mice.test.ts— importLAMZU_INCA_PRODUCTSand spread its keys intoPID_UNIVERSE.supported-mice.ts— flip this row tosupportedand shorten the note.Neither compiles without the other, so they belong in one commit after the bump.
Two things deliberately not changed
"Inca", not"Inca 8K".supported-live.tsoverlays request votes by normalizedbrand|model, and its word-overlap matcher returns early for single-word model names. Renaming this row would silently orphan thereq: 1it already carries.LAMZU_INCA_PRODUCTSloop was added toregistrySupportedModels(). That function emitsmodel: info.model, which is"Inca 8K"— a differentbrandModelKeyfrom this row, so the dedupe would miss it and the supported-devices page would list the same mouse twice.Verification
npm run checkpasses against the currently published@openmouse/protocol—tsc --noEmit && vite buildclean, 112/112 tests. Also verified green against a local build of mouse-protocol#45, so it stays passing after that merges.No device artwork is included:
ui/device-images.tshas no37b0:*mapping, so the Inca resolves tounknown-device.png, which is the same treatment Orbital and moddo get today. Happy to add the mapping once art exists in the bucket.