Part of #206 (Phase 0). Depends on nothing.
Why
/merchandise shows one T-shirt with a link to an outside shop. It is linked from nowhere: not the navbar, not the footer, not the sitemap, not any of the seven new pages. The route comment in config/routes.rb:102-104 says it was kept because "the shop is expected back, plausibly through Open Collective, and deleting them would mean writing it all again". Decision taken for this epic: retire it. A page nobody can reach is not a shop, and one product card is not worth carrying through a restyle and three languages. When there is something to sell, the page is written for what is sold.
What to change
- Remove the route and its comment (
config/routes.rb:102-105), PagesController#merchandise (the only action here with a hardcoded English @page_title), app/views/pages/merchandise.html.erb, and the T-shirt image if nothing else uses it.
- Remove
pages.merchandise and its children from config/locales/pages.{en,ru,zh}.yml, and the unused nav.store key from the three top-level locale files.
- Remove the page from
test/controllers/legacy_pages_test.rb (the smoke entry and merchandise lists each product once at lines 61-65).
/merchandise then falls through to the catch-all like every other retired URL. No redirect: there is no page that stands for it.
Done means
GET /merchandise answers like any unknown path.i18n-tasks unused drops by the number of keys removed and missing stays clean.bin/rails test green; rubocop adds nothing to the touched files.
Part of #206 (Phase 0). Depends on nothing.
Why
/merchandiseshows one T-shirt with a link to an outside shop. It is linked from nowhere: not the navbar, not the footer, not the sitemap, not any of the seven new pages. The route comment inconfig/routes.rb:102-104says it was kept because "the shop is expected back, plausibly through Open Collective, and deleting them would mean writing it all again". Decision taken for this epic: retire it. A page nobody can reach is not a shop, and one product card is not worth carrying through a restyle and three languages. When there is something to sell, the page is written for what is sold.What to change
config/routes.rb:102-105),PagesController#merchandise(the only action here with a hardcoded English@page_title),app/views/pages/merchandise.html.erb, and the T-shirt image if nothing else uses it.pages.merchandiseand its children fromconfig/locales/pages.{en,ru,zh}.yml, and the unusednav.storekey from the three top-level locale files.test/controllers/legacy_pages_test.rb(the smoke entry andmerchandise lists each product onceat lines 61-65)./merchandisethen falls through to the catch-all like every other retired URL. No redirect: there is no page that stands for it.Done means
GET /merchandiseanswers like any unknown path.i18n-tasks unuseddrops by the number of keys removed andmissingstays clean.bin/rails testgreen;rubocopadds nothing to the touched files.