Improve screen reader, keyboard, and High Contrast accessibility - #2518
Improve screen reader, keyboard, and High Contrast accessibility#2518jbgrimsby wants to merge 1 commit into
Conversation
|
Hi, just following up on this PR now that it has been ready for review for a few weeks. It corrects long-standing screen-reader and keyboard accessibility problems in the Open-Shell settings dialogs and includes tested changes for NVDA, standard Windows tree navigation, control roles and states, focus handling, and High Contrast support. I would appreciate a review when someone has time. I’m happy to answer questions, provide the inspection evidence, or revise and split the changes if that would make review easier. |
|
Hello and thank you for your effort. I'm sorry, I didn't have much time to look at these changes :( Please, try to install build from this PR and double-check everything works for you as well. |
Summary
This change corrects screen-reader and keyboard interaction in the Start Menu, Classic Explorer, and Classic IE settings dialogs while preserving the existing visual workflow.
It also makes the new-application indicator respect the Windows High Contrast palette, addressing the color conflict described in #2054.
What changed
modifiedonly when a setting differs from its default, matching the existing bold visual treatment.Root cause
The settings interface visually represented checkbox, radio-button, selected, default, and modified states through custom tree images and bold text, but exposed the items to assistive technology as generic outline items. Some keyboard behavior was also implemented differently from standard Windows tree and property-page interaction.
The new-application indicator could additionally use a skin foreground color as a background under High Contrast, producing unreadable adjacent items.
Validation
CallCancelledexception occurred during that run. This single run is positive evidence but does not claim that the separate intermittent report is conclusively resolved.User impact
Screen-reader users can determine which settings are selected or modified, navigate the trees using standard Windows conventions, and move through the dialogs in a predictable order. Sighted users retain the existing layout, bold modified-setting indication, and normal theme rendering.