use of xarray instead of the MFDatasetCommonDims class - #3187
Open
JanEisermann wants to merge 3 commits into
Open
use of xarray instead of the MFDatasetCommonDims class#3187JanEisermann wants to merge 3 commits into
JanEisermann wants to merge 3 commits into
Conversation
ReimarBauer
requested changes
Sep 11, 2026
Member
There was a problem hiding this comment.
until Joern looked on that I hold it blocked.
@joernu76 already was against thi change in a different PR
joernu76
reviewed
Sep 14, 2026
| logging.debug("opening datasets.") | ||
| dsKWargs = self.data_access.mfDatasetArgs() | ||
| dataset = netCDF4tools.MFDatasetCommonDims(self.filenames, **dsKWargs) | ||
| dataset = netCDF4tools.open_mfdataset_commondims( |
Member
There was a problem hiding this comment.
can xarray.open_mfdataset be used here? That would really remove code?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #3185
Does this PR introduce a breaking change?
use of xarray instead of the MFDatasetCommonDims class, which is removed within this PR
If the changes in this PR are manually verified, list down the scenarios covered::
tests succeeded, not manually verified
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>with help by Claude