use a rubber band selection for moving or deleting multiple waypoints - #3183
Closed
ReimarBauer wants to merge 2 commits into
Closed
use a rubber band selection for moving or deleting multiple waypoints#3183ReimarBauer wants to merge 2 commits into
ReimarBauer wants to merge 2 commits into
Conversation
Member
|
Nice, but this introduces 329 lines-of-code in an already questionable part of the code (this broke a lot in the past) for making it slightly more comfortable to work with (I admit, there are some use cases). In light of keeping things manageable I propose to reject both the MR and the issue. |
Member
Author
|
We can reopen this issue when we plan to refactor that section of the path interactor. I previously attempted a manual implementation, but we should aim to avoid a situation where a model becomes a necessity for this specific area of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1576
mutilselection_example.mp4
with support from claude