ci: archive the proto baseline from the api/proto subtree and retry the cvc5 download - #497
Merged
Merged
Conversation
…he cvc5 download Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Both red jobs on
developatbd59ac7are infrastructure, not code:Go static checks —
make proto-breakingbuilt the baseline withgit archive HEAD^1 api/proto. A pathspec makesgit archivewalk the whole tree ofHEAD^1, and on CircleCI's blobless (promisor) checkout that lazily fetches every blob the parent commit does not share with the checkout. The fetch goes to the promisor remote over SSH, which the executor cannot authenticate to, so the job died withPermission denied (publickey)/could not fetch … from promisor remoteon a merge that touched no.protofile.Fix: archive the subtree as the tree-ish instead —
git archive 'HEAD^1:api/proto'. Only that subtree's objects are read, and they are already present because the checkout'sapi/protoshares them. The archive root is now the proto directory, sobuf breaking … --against "$baseline#format=tar"dropssubdir=api/proto.Go race tests — died in
Install cvc5on a single failedcurlof the GitHub release asset. Added--retry 5 --retry-delay 5 --retry-all-errors; the SHA-256 pin is unchanged.How it was verified
--filter=blob:noneclone with the SSH promisor URL: the old pathspec form fetches and fails, the tree-ish form archives without any fetch andbuf breakingreports✓ No breaking schema changes.make proto-breaking BUF_BREAKING_REF=HEAD^1andBUF_BREAKING_REF=origin/developpass on this branch.python3 scripts/changelog.py check,gofmt -l .,go vet ./...,make lint,make buildpass.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelog