Conversation
nan-li
marked this pull request as draft
September 18, 2026 16:31
- Set IPHONEOS_DEPLOYMENT_TARGET to 15.0 on every target in OneSignal.xcodeproj and OneSignalExample.xcodeproj. Xcode 27 rejects anything lower, so the project did not build on it - Declare iOS 15 in both podspecs and Package.swift. CocoaPods stamps the podspec platform onto the pod target, which is what broke CocoaPods consumers on Xcode 27 - Update the README, the migration guide and the bug report template's iOS version list
nan-li
force-pushed
the
nan/sdk-5280
branch
from
September 18, 2026 16:56
8eaf929 to
2816e0e
Compare
nan-li
marked this pull request as ready for review
September 18, 2026 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Raise the minimum iOS version from 12 to 15. SDK-5280.
Details
Motivation
Xcode 27 refuses to build anything with a deployment target below iOS 15. That broke this project for local development and broke CocoaPods customers on Xcode 27, because CocoaPods copies the podspec's platform version onto the pod target. Swift Package Manager customers were not affected.
Scope
Testing
Unit testing
No test changes.
Manual testing
Built the test app on Xcode 27.0 with no command-line override and ran the OSCore tests and the subscription race tests on an iPhone 17 Pro simulator. 187 tests, all passing.
Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code