chore: Spelling - #204
Closed
jsoref wants to merge 15 commits into
Closed
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref
commented
Oct 13, 2023
Contributor
Author
There was a problem hiding this comment.
The changes probably can't be made, but they're unfortunate, and I'm using this PR to call them out...
There was a problem hiding this comment.
This device is being used by a 9 yr old kid right now. I don't want to be mistreated again as what happened before.
No cla signet yet.
| } | ||
|
|
||
| // SetPrivateKeyPassphrase sets the private key [assphrase of this SSH key pair account. | ||
| // SetPrivateKeyPassphrase sets the private key passphrase of this SSH key pair account. |
| IDs []string `uri:"ids,omitempty" url:"ids,omitempty"` | ||
| IncludeSystem bool `uri:"includeSystem,omitempty" url:"includeSystem,omitempty"` | ||
| Internal string `uri:"interal,omitempty" url:"interal,omitempty"` | ||
| Internal string `uri:"internal,omitempty" url:"internal,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
Changes like this are scary, as it's an API of sorts...
| } | ||
|
|
||
| const ManualInterverventionApprove = "Proceed" | ||
| const ManualInterventionApprove = "Proceed" |
Contributor
Author
There was a problem hiding this comment.
This is probably an API of sorts and thus probably can't be done either.
| sshEndpoint := struct { | ||
| AccountID string `json:"AccountId,omitempty"` | ||
| ComunicationStyle string `json:"CommunicationStyle" validate:"required,eq=Ssh"` | ||
| CommunicationStyle string `json:"CommunicationStyle" validate:"required,eq=Ssh"` |
Contributor
Author
There was a problem hiding this comment.
This could be an API too...
| } | ||
| if result.explode && result.truncate > 0 { | ||
| err = errors.New("both explode and prefix modifers on same term") | ||
| err = errors.New("both explode and prefix modifiers on same term") |
Contributor
Author
There was a problem hiding this comment.
I'm hoping nothing cares about the spelling of error messages.
|
No CLA Signed yet. |
|
Octo deployment is not clear. No assistance received ever. |
|
Continue blocked the merging. |
Contributor
|
Thanks @jsoref, and apologies this sat so long. Carried forward to #448, rebased onto Closing in favour of #448. |
NickJosevski
added a commit
that referenced
this pull request
Aug 20, 2026
Rebases the corrections from #204 onto main. Three are behavioural rather than cosmetic: the events query sent "interal" so the Internal filter never reached the server, ManualInterverventionApprove gains a correctly spelled name while the misspelling stays as a deprecated alias, and uritemplates.parseTerm's error text changes from "modifers" to "modifiers". The parseTerm message is observable to anyone matching on that string, so it is called out for release notes even though it is an internal parse error. Co-Authored-By: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
added a commit
that referenced
this pull request
Aug 20, 2026
Rebases the corrections from #204 onto main. Three are behavioural rather than cosmetic: the events query sent "interal" so the Internal filter never reached the server, ManualInterverventionApprove gains a correctly spelled name while the misspelling stays as a deprecated alias, and uritemplates.parseTerm's error text changes from "modifers" to "modifiers". The parseTerm message is observable to anyone matching on that string, so it is called out for release notes even though it is an internal parse error. Co-Authored-By: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
added a commit
that referenced
this pull request
Aug 21, 2026
Rebases the corrections from #204 onto main. Three are behavioural rather than cosmetic: the events query sent "interal" so the Internal filter never reached the server, ManualInterverventionApprove gains a correctly spelled name while the misspelling stays as a deprecated alias, and uritemplates.parseTerm's error text changes from "modifers" to "modifiers". The parseTerm message is observable to anyone matching on that string, so it is called out for release notes even though it is an internal parse error. Co-Authored-By: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm skipping conventional commits for now, I'm happy to apply such conventions once the general content is discussed. I expect some of the items I'm flagging here can't be done...