test(validation): check context equality over every schema, not thirteen - #153
Merged
Merged
Conversation
The equivalence was pinned on the examples only, which is half the corpus and the half least likely to break it. The compliance fixtures carry as many schemas again and exist precisely to hold the unusual constructs. Adds the same sweep to the parity suite, so it runs against whatever oold-schema main has now rather than against the snapshot taken when the fixture slice was cut - that is where a construct which breaks the claim would show up first.
Contributor
Release previewNo version bump from the current commits (stays at Changelog preview (truncated)Preview via python-semantic-release and conventional commits. |
Contributor
📊 Benchmark ResultsClick to see benchmark comparisonThreshold: 1.3x (30% slower triggers a regression warning) Note: Benchmarks are informational only and won't fail the build. 💡 Tip: Download the |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #150, which pinned the pyld equivalence on the committed examples only.
What was and was not covered
@contextmainThe untested half is the half that matters. The compliance fixtures exist to hold the unusual constructs, so pinning the equivalence on the examples alone tested it against the documents least likely to break it.
Measured before wiring it in: all three corpora agree, 0 divergences, 0 errors.
Changes
tests/data/oold/compliance/as well, 13 -> 26 schemasOOLD_SCHEMA_DIR, so it tracksmaininstead of the snapshot the fixture slice was cut fromconftest.embedded_schemasso both use one copyWhy this belongs in parity too
context_resolution's docstring argues from what pyld does not return. A snapshot can only hold that against constructs upstream had when it was taken; a new one that breaks the claim appears onmainfirst, and the parity job is the only thing that looks there.Verification
pytest tests/test_validation: 498 passed, 7 skippedpre-commit: clean