Fix Episodes anchor case in OncologyWG links - #810
Open
asharaali wants to merge 1 commit into
Open
Conversation
The EPISODE documentation links point at model.html#Episodes, but the OncologyWG page renders that section as id="episodes". The fragment does not resolve, so the reader lands at the top of the page instead of the Episodes section. Lowercases the fragment in the 5.4 and 5.5 specification CSVs and in the rendered pages. Signed-off-by: Ashar Ali <aaa467@njit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EPISODE documentation links point at
model.html#Episodes, but the OncologyWG page renders that section asid="episodes". The fragment doesn't resolve, so the link lands the reader at the top of the page rather than the Episodes section.The page has
id="episode",id="episode_event"andid="episodes"— no capitalised variant.Changed the fragment to
#episodesin:inst/csv/OMOP_CDMv5.4_Table_Level.csv(episode, ETL conventions)inst/csv/OMOP_CDMv5.5_Table_Level.csv(same row, carried into 5.5)inst/csv/OMOP_CDMv5.5_Field_Level.csv(episode.episode_concept_id)docs/cdm54.html,docs/cdm55.html— the corresponding rendered pagesSix characters, all
Etoe.Verified the CSVs still parse to the same shape after the edit — same row count, same field count per row, and a single differing cell in each file. The DDL tests read the schema columns rather than the prose ones, so this doesn't touch them; I didn't run them locally as
test-executeDdl.Rwants a database.Refs #802. Not a full fix for that issue — it covers only the one link that had a real target and the wrong case. The four bare
[article]placeholders inOMOP_CDMv5.4_Field_Level.csvare a separate problem: three of them have no page to point at yet (the OncologyWG Episodes section is still marked "Under Construction"), and choosing targets for them is an ETL-conventions decision rather than a typo. Leaving #802 open for that reason.