[18.0][FIX] odoo_repository: Avoid cache corruption - #155
Open
lmignon wants to merge 1 commit into
Open
Conversation
@tools.ormcache is a process-wide cache that is never invalidated by a SQL ROLLBACK. If a newly created record's id were cached from within the caller's (still uncommitted) transaction, and that transaction was later rolled back for an unrelated reason (e.g. a conflicting concurrent queue job), the cache would keep returning an id that no longer exists in the database. This commit add a new method creating and committing the record, independently of the caller's transaction. That guarantees the returned id always stays valid, whatever happens to the caller's job afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tools.ormcache is a process-wide cache that is never invalidated by a SQL ROLLBACK. If a newly created record's id were cached from within the caller's (still uncommitted) transaction, and that transaction was later rolled back for an unrelated reason (e.g. a conflicting concurrent queue job), the cache would keep returning an id that no longer exists in the database.
This commit add a new method creating and committing the record, independently of the caller's transaction. That guarantees the returned id always stays valid, whatever happens to the caller's job afterwards.