Conversation
Notifying user to define selected attribute_field_id of supported type from vector layer as part of geoengine view xml defintion which avoids observed JS error.
anusriNPS
force-pushed
the
17.0-fix-geoview
branch
from
September 16, 2026 05:10
2b71ab1 to
cdea980
Compare
max3903
reviewed
Sep 16, 2026
max3903
left a comment
Member
There was a problem hiding this comment.
Code review
Verdict: approve with nits — sensible forward-port of merged #417; please fix the it.po header regression before merge.
What it does
When a vector layer’s attribute_field_id isn’t available on the loaded records (typically missing from the geoengine view fields), styling/legend used to blow up in JS. This adds checkAttributeFieldUsage(), shows a warning notification, and skips style/legend setup.
Good
- Matches the already-merged 16.0 fix (#417); same approach.
- Early-outs around
styleVectorLayer/initLegend/setStyleavoid cascading errors. - User-facing
_t+ notification is better than a console exception. - CI is green.
Should fix
it.poheader wipe — this diff dropsLanguage: it, WeblatePlural-Forms,Last-Translator, andX-Generator. Please only add the new msgid and restore the previous header metadata.- Null-safe
attribute_field_id—extractLayerValuesstill doescfg.attribute_field_id[1]with no guard. Prefer an early return incheckAttributeFieldUsage:
if (!cfg.attribute_field_id) {
return true;
}(Same concern was already raised on #417.)
Nits
- Warning can fire on every domain/layer refresh → possible notification spam.
- PR body is only
FW #417— a short “why” would help reviewers. - Please add the
needs reviewlabel.
Process
Age 0 days / 0 approvals so far — not merge-ready yet under OCA policy (5 days + 2 reviews). Related consumer: OCA/field-service#1621.
anusriNPS
marked this pull request as draft
September 17, 2026 04:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FW #417