Skip to content

ci: run on pull requests against any base branch - #32

Closed
petlenz wants to merge 2 commits into
mainfrom
ci/run-on-all-pull-requests
Closed

ci: run on pull requests against any base branch#32
petlenz wants to merge 2 commits into
mainfrom
ci/run-on-all-pull-requests

Conversation

@petlenz

@petlenz petlenz commented Aug 18, 2026

Copy link
Copy Markdown
Member

The pull_request trigger filtered on branches: [main], so a PR targeting a feature branch matched nothing.

Work in this repo lands through stacks — #27, #28, #29, #30 and #31 all target a feature branch — and not one of them has ever been built or tested by CI. The most recent workflow run of any kind is main from 2026-07-28.

   push:
     branches: [main]
   pull_request:
-    branches: [main]

Dropping the filter runs the job for every pull request whatever its base. The push trigger keeps its main filter, so branch pushes add no load — a stacked branch is covered by its own PR rather than by pushes to it.

The job body needed no change: NUMSIM_BUILD_TESTS and NUMSIM_BUILD_EXAMPLES are the real option names in CMakeLists.txt, and g++-14 is installed and selected, which the <print> uses in the examples and plot targets require.

Branched from main rather than folded into one of the stacked PRs, since the trigger is repo policy and not part of any feature. It has been merged into each of #27#31 as well, because pull_request runs the workflow from the PR's merge ref — the fix has to be present on a head branch for that PR to get a run.

The pull_request trigger filtered on branches: [main], so a PR targeting a
feature branch matched nothing. Work here lands through stacks -- #27..#31 all
target a feature branch -- and not one of them has ever been built or tested by
CI. The last run of any kind was main, three weeks ago.

Dropping the filter runs the job for every pull request whatever its base. The
push trigger keeps its main filter, so branch pushes add no load: a stacked
branch is covered by its own PR.
@petlenz

petlenz commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Third review pass. No findings — three lines, and it does exactly what it says.

Worth recording what it has bought since merging into the stack: seven real defects surfaced, none of which any local build here could reach, because find_package succeeds on this machine for both Eigen and nlohmann and the fetch path therefore never ran.

@petlenz

petlenz commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

This PR is redundant — recommend closing unmerged.

Verified by containment: ci/run-on-all-pull-requests is a strict ancestor of every other open branch, including feature/drucker-prager (#10), which also targets main.

ci/run-on-all-pull-requests  <  feature/drucker-prager      (#10 -> main)
ci/run-on-all-pull-requests  <  feature/vector-solver       (#17)
ci/run-on-all-pull-requests  <  ...and all 8 others

So merging #10 delivers this change to main regardless. Merging both is harmless but adds a PR to track for no content.

The one argument for keeping it: it is 3 lines against #10's 4176, so merging it first turns CI on for main immediately rather than waiting on a large review. If #10 is not close to merging, that is worth something. If it is, close this.

Its value is already banked either way — turning the trigger on surfaced seven latent defects across #10, #17 and #30, none of which any local build here could reach.

@petlenz petlenz closed this Sep 6, 2026
@petlenz

petlenz commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Closing as redundant: feature/drucker-prager (#10) already removes the branches: [main] filter, and every PR in the stack inherits it. Once #10 lands on main, this diff is empty.

@petlenz
petlenz deleted the ci/run-on-all-pull-requests branch September 6, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant