ci: run on pull requests against any base branch - #32
Conversation
The pull_request trigger filtered on branches: [main], so a PR targeting a feature branch matched nothing. Work here lands through stacks -- #27..#31 all target a feature branch -- and not one of them has ever been built or tested by CI. The last run of any kind was main, three weeks ago. Dropping the filter runs the job for every pull request whatever its base. The push trigger keeps its main filter, so branch pushes add no load: a stacked branch is covered by its own PR.
|
Third review pass. No findings — three lines, and it does exactly what it says. Worth recording what it has bought since merging into the stack: seven real defects surfaced, none of which any local build here could reach, because |
|
This PR is redundant — recommend closing unmerged. Verified by containment: So merging #10 delivers this change to The one argument for keeping it: it is 3 lines against #10's 4176, so merging it first turns CI on for Its value is already banked either way — turning the trigger on surfaced seven latent defects across #10, #17 and #30, none of which any local build here could reach. |
The
pull_requesttrigger filtered onbranches: [main], so a PR targeting a feature branch matched nothing.Work in this repo lands through stacks — #27, #28, #29, #30 and #31 all target a feature branch — and not one of them has ever been built or tested by CI. The most recent workflow run of any kind is
mainfrom 2026-07-28.push: branches: [main] pull_request: - branches: [main]Dropping the filter runs the job for every pull request whatever its base. The
pushtrigger keeps itsmainfilter, so branch pushes add no load — a stacked branch is covered by its own PR rather than by pushes to it.The job body needed no change:
NUMSIM_BUILD_TESTSandNUMSIM_BUILD_EXAMPLESare the real option names in CMakeLists.txt, andg++-14is installed and selected, which the<print>uses in the examples and plot targets require.Branched from
mainrather than folded into one of the stacked PRs, since the trigger is repo policy and not part of any feature. It has been merged into each of #27–#31 as well, becausepull_requestruns the workflow from the PR's merge ref — the fix has to be present on a head branch for that PR to get a run.