Simplify memory core and protect snapshots and concurrent reads - #7
Merged
Merged
Conversation
Ninadnj
marked this pull request as ready for review
September 16, 2026 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returned Python entries previously exposed live store state: changing a result could bypass revisions and leave text inconsistent with its search vector. Concurrent reads could also observe a change whose disk save later failed.
This candidate makes returned entries independent snapshots and serializes operations within each store object. Record rules and JSON persistence now have explicit modules;
MemoryStorecontinues to own memory operations, retrieval and transactions. Existing format-3 data and IDs remain compatible.Other changes:
dedup_thresholdwithdeduplicate=False; makeagentkeyword-only in the Python write APIs.Validation on macOS / Python 3.12:
The new regression suite reproduced failures before implementation. Retrieval quality is unchanged; semantic-model and live-agent performance remain unverified. See
docs/migration-v0.4.mdbefore upgrading Python callers.The pre-merge fixes add ten regression cases (9 failed before the fixes, all 10 now pass), covering cross-instance startup consistency, literal markers, persisted-memory budgets, and MCP roundtrips.