Skip to content

Fixed Estonian flag bug - #5789

Open
quokkawiki wants to merge 1 commit into
NginxProxyManager:developfrom
quokkawiki:develop
Open

Fixed Estonian flag bug#5789
quokkawiki wants to merge 1 commit into
NginxProxyManager:developfrom
quokkawiki:develop

Conversation

@quokkawiki

Copy link
Copy Markdown

Why

The Estonian flag was appearing as an Ethiopian flag, due to a mixup of ISO 639 language codes and ISO 3166 country codes. The Estonian language code is et, but the country code ET corresponds to Ethiopia.

Although I think the best long-term fix for this is to either remove specialCases and instead rely on a BCP 47 language tag, which shows both the locale and region (e.g. et-EE), or better yet, ditch the flags entirely because languages do not correlate with countries.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • API changes
  • Performance improvement
  • Test addition or update

AI Usage

  • AI was used to write this
  • AI was used to review this

The Estonian flag was appearing as an Ethiopian flag, due to a mixup of ISO 639 language codes and ISO 3166 country codes
@nginxproxymanagerci

Copy link
Copy Markdown

Docker Image for build 1 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-5789

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant