Skip to content

Update verifications controller and add instruction to README - #1

Open
hummusonrails wants to merge 3 commits into
Nexmo:mainfrom
hummusonrails:update-verifications-controller
Open

Update verifications controller and add instruction to README#1
hummusonrails wants to merge 3 commits into
Nexmo:mainfrom
hummusonrails:update-verifications-controller

Conversation

@hummusonrails

Copy link
Copy Markdown

In this PR I've addressed two areas:

  • Fixed the Nexmo API syntax to correctly verify a user in the verifications_controller.
  • Updated the README to include the rake db:migrate step in the installation, since without it the user will encounter an error when attempting to boot up the server for the first time.

@lornajane

Copy link
Copy Markdown

@benhayehudi , this looks valuable to me. Who can review this and get it accepted?

@hummusonrails

Copy link
Copy Markdown
Author

@benhayehudi , this looks valuable to me. Who can review this and get it accepted?

Wow, haven't seen this in a while! Looping in @fabianrbz to review.

@fabianrbz

Copy link
Copy Markdown

@benhayehudi @lornajane it looks good to me, but i don't understand where the changes are coming from. Was the controller broken and this fixes it? or did we update the nexmo gem?

@hummusonrails

Copy link
Copy Markdown
Author

@benhayehudi @lornajane it looks good to me, but i don't understand where the changes are coming from. Was the controller broken and this fixes it? or did we update the nexmo gem?

Yep, to both questions. I created this it looks like the first week I joined the team.

@fabianrbz

Copy link
Copy Markdown

@benhayehudi should we update the Gemfile.lock or does the specified version support this change?

@mheap
mheap changed the base branch from master to main February 2, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants