fix(monitoringapi): remove the vc missing validators ready check - #687
Open
varex83agent wants to merge 1 commit into
Open
fix(monitoringapi): remove the vc missing validators ready check#687varex83agent wants to merge 1 commit into
varex83agent wants to merge 1 commit into
Conversation
The check served 500 `vc missing validators` forever whenever not every key in a cluster was active, since the beacon node only returns duties for active validators and the expected set can never be fully observed. Charon deleted the same check in v1.10.0 (ObolNetwork/charon#4359) for this exact failure mode; its v1.11.0 readiness chain ends at `vc not connected`. This drops `ValidatorClientMissingValidators`, retires readyz code `6`, and removes the seen-pubkeys observation plumbing that existed only to feed it. Closes #683. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #683.
/readyznever became ready when not every key in a cluster was active: the beacon node onlyreturns duties for active validators, so the expected pubkey set could never be fully observed and
the node served
500 vc missing validatorswithapp_monitoring_readyzstuck at6while everyactive validator did its duties normally.
Charon deleted the same check in v1.10.0 (ObolNetwork/charon#4359) for this exact failure mode, and
its v1.11.0 readiness chain ends at
vc not connected. This removesValidatorClientMissingValidators, retires readyz code6(the remaining codes are unchanged —7/8keep their values, matching charon'sapp/metrics.go), and drops the seen-pubkeysobservation plumbing that existed only to feed it.
/readyzstill reportsvc not connected(code
5) when the VC makes no validator API calls during an epoch.Co-Authored-By: Bohdan Ohorodnii 35969035+varex83@users.noreply.github.com