refactor(qbft): make MessageType/UponRule enums and remove panic - #685
Merged
Conversation
varex83
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #637
MessageTypeandUponRulewerei64newtypes, so nomatchwas exhaustive and the catch-all arms panicked. They are now#[repr(i64)]enums with unchanged discriminants; theMSG_*/UPON_*consts stay as aliases so call sites and the parity suites are untouched.TryFrom<i64> for MessageTypeaccepts1..=5and is now the single admission check at the wire boundary.panic!("bug: …")sites returnQbftError::SanityCheck, mirroring charon'sqbft sanity check: %vrecovery. Payloads match charon byte-for-byte.catch_unwindcalls removed frominternal_test.rs; the 14.expect()sites are untouched.The nested-justification panic from the issue was already unreachable from the wire (proto cannot express nesting, constructor flattens,
verify_msgtype-gates). The gain is that the one wire-reachable sanity failure now surfaces as a typed error with a metric instead of an untypedError::Join.