fix(api): keep cookies out of process argv and redact logs contextually - #975
Open
saksim wants to merge 1 commit into
Open
fix(api): keep cookies out of process argv and redact logs contextually#975saksim wants to merge 1 commit into
saksim wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebUI places platform cookies in child-process argv and its startup log. Pass them through MEDIACRAWLER_COOKIES instead, hide the field from the request model repr, hide environment values in CLI help, and disable CLI exception-local display.
Redact Cookie headers and known cookie key/value representations rather than replacing arbitrary value substrings. This preserves page counts, flags, timezones, and identifiers when cookies contain common values such as 1, 0, or true.
Validation: the original implementation fails 7 of 8 new tests. The same tests also catch overbroad substring redaction. The isolated upstream branch passes all 104 tests (Python 3.11, Windows with PYTHONUTF8=1), covering argv/env transport, logs, repr, CLI help/argument precedence, cookie dictionaries/headers, and preservation of unrelated text. Popen is mocked and no account is started.
--cookies remains supported for compatibility. Environment variables are not encrypted storage against the same OS account or administrators. See docs/cookie-handling.md. Access control and JSONL are separate PRs.
Fork tracking and CI: PR #24. Related report: saksim#2.