fix(database): propagate MongoDB upsert failures - #970
Open
saksim wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MongoDBStoreBase.save_or_update catches write failures and returns False, while platform stores ignore that return value and continue to log success. Propagating the original exception prevents failed writes from appearing successful. Successful upserts still return True and use the same query/update semantics.
Custom callers must handle the exception or fail the task instead of relying on False. This is documented in docs/mongodb-write-errors.md. No schema migration or retry policy is introduced.
Validation: on the original code, 2 failure-path tests fail and the success-contract test passes. The isolated upstream branch passes all 99 tests (Python 3.11, Windows with PYTHONUTF8=1). AsyncMock covers driver failures, successful upserts, and suppression of false success logs through a platform store. No live MongoDB service is used.
This PR only addresses failed MongoDB writes. Fork tracking and CI: PR #19. Related report: saksim#7.