Conversation
Warn operators before stack upgrades activate the NVCA validating webhook. Document required chart limits, temporary negative feature-gate overrides, and post-rollout verification. Refs: #1888 Signed-off-by: Stephanie Baum <sbaum@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe cluster configuration documentation now describes Helm CPU and memory limit enforcement, temporary feature-gate overrides, and compute-plane commands for applying and verifying these settings. ChangesHelm resource-limit enforcement
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~8 minutes Change: Other · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to No actionable risk is currently established for this documentation-only change. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The reported documentation update addresses the enforcement boundaries, container limits, negative feature-gate overrides,
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Comment |
|
🌿 Preview your docs: https://nvidia-preview-docs-helm-resource-limit-upgrades.docs.buildwithfern.com/nvcf |
TL;DR
Document NVCA Helm workload resource-limit enforcement before self-managed
stack upgrades activate it. The guide covers required chart changes, the
temporary compatibility override, and post-upgrade verification.
Additional Details
Why
Self-managed stack upgrades can begin rejecting existing Helm function and
task charts that omit CPU or memory limits. Operators need the release
boundaries and remediation steps before updating their compute plane.
What changed
Helm workload resource-limit enforcement.
rendered by Helm function and task charts.
HelmResourceConstraintsdoes not disable thesechecks.
commands.
Customer Release Notes
Documents Helm workload resource requirements and a temporary compatibility
override for self-managed compute-plane upgrades.
Plan Summary
No cluster resources change in this PR. The guide documents existing NVCA and
compute-plane stack behavior.
Usage
Update Helm workload charts before upgrading. Use the negative feature-gate
overrides only when a legacy chart cannot be updated before the upgrade, then
remove the overrides after adding resource limits.
Testing
./tools/ci/check-docs: passed with zero errors and one Fern warning.Notes
v0.6.1release notes are unchanged.References
Related Pull Requests
Dependencies
None.
For the Reviewer
Review the version boundaries, feature-gate semantics, and compute-plane
verification commands.
For QA
No additional QA is needed. This PR changes documentation only, and the
behavior is covered by the BDD scenarios in #1890.
Issues
Closes #1888
Checklist
compliance.
Summary by CodeRabbit