test(pathfinder): place Windows arm64 cudart test fixtures under bin/arm64 - #2528
Open
rluo8 wants to merge 1 commit into
Open
test(pathfinder): place Windows arm64 cudart test fixtures under bin/arm64#2528rluo8 wants to merge 1 commit into
rluo8 wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
cuda.pathfinder
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to fix test case test_try_via_ctk_root_regular_lib failure on native win-arm64.
Root cause: After pathfinder became architecture-aware, native ARM64 Python only searches CTK cudart under bin/arm64 (no flat bin/ fallback). The test helper_create_cudart_in_ctk still always wrote bin/cudart64_12.dll, so find_via_ctk_root
returned None and the assert failed for arm64.
The fix is to make _create_cudart_in_ctk place the fake DLL under bin/arm64 when windows_python_arch() == "arm64".