[PyTorch] Fix MXFP8 master weight cast when a rank owns no shard. - #3348
Open
rapatel wants to merge 2 commits into
Open
[PyTorch] Fix MXFP8 master weight cast when a rank owns no shard.#3348rapatel wants to merge 2 commits into
rapatel wants to merge 2 commits into
Conversation
Signed-off-by: Ritesh Patel <ripatel@nvidia.com>
Contributor
Greptile SummaryThis PR fixes MXFP8 master-weight casting when a rank owns no shard by deriving the fallback amax-buffer dtype from the quantized model weight. It also adds regression coverage for empty and populated shards and safely tears down a process group created by the test fixture. Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "[PyTorch] Destroy the process group crea..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix MXFP8 master weight cast when a rank owns no shard.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: