-
Notifications
You must be signed in to change notification settings - Fork 805
[JAX] Return max_logit from TE fused attn #3112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KshitijLakhani
wants to merge
22
commits into
NVIDIA:main
Choose a base branch
from
KshitijLakhani:klakhani/feat/return-softmax-stats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3ab4725
Add support in lower level JAX API for returning max logit and softma…
KshitijLakhani 84f180a
Add support for returning reduced per head max logit. Plumb max logit…
KshitijLakhani 8f565cf
Add max logit to JAX fused attn FFI and set it in the workspace
KshitijLakhani 31ede58
Add first pass tests for max logit and softmax aux tensor outputs in …
KshitijLakhani dde413b
Reject aux returns with score_mod
KshitijLakhani 9da2226
Handle SM120 max-logit layout
KshitijLakhani 38ce6e3
Drop softmax aux return
KshitijLakhani 3198726
Modify static args in fused attn tests for jax
KshitijLakhani e56b971
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cbe18ac
nit: Inline the choice of what is to be returned and remove redundant…
KshitijLakhani 7f9977e
Expose JAX max logit
KshitijLakhani de929ba
Support CP max logit
KshitijLakhani 78c8828
Expand JAX max logit tests
KshitijLakhani e36a4a0
Remove JAX max logit integration tests
KshitijLakhani 9b537ba
Broaden JAX CP max logit tests
KshitijLakhani bb7ce9b
Reduce JAX max logit across DP
KshitijLakhani c093329
Simplify JAX max logit return
KshitijLakhani 0f7bb0b
Document JAX max logit reductions
KshitijLakhani 90a3eaf
Refine JAX max logit tests
KshitijLakhani 704957a
Rename JAX max logit buffer
KshitijLakhani 2e71bc8
Check JAX attention tensor pack capacity
KshitijLakhani d7bf4cf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run L1 CI on this PR? I don't see a CI run
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had run the test suite locally only. Launched CI right now. Thanks for the reminder !