Skip to content

feat(gateway,cli): windows compilation support - #2496

Open
araza008 wants to merge 50 commits into
NVIDIA:mainfrom
araza008:windows_compilation
Open

feat(gateway,cli): windows compilation support#2496
araza008 wants to merge 50 commits into
NVIDIA:mainfrom
araza008:windows_compilation

Conversation

@araza008

@araza008 araza008 commented Jul 27, 2026

Copy link
Copy Markdown

Summary

compile the OpenShell gateway and CLI natively on Windows MSVC for x86-64 and arm64. It is build support only. It does not add functional Windows support for MXC, the sandbox supervisor, or Windows services.

Related Issue

Changes

adds windows mise tasks
supports bundled-z3 with optional system z3
gates unix-only dependencies so the geteway and cli compile on windows
adds linting and pre-commit tasks

Testing

mise run --skip-tools windows:build:x64
mise run --skip-tools windows:build:arm64

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@copy-pr-bot

copy-pr-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@araza008

Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

1 similar comment
@jamieknvidia

Copy link
Copy Markdown

I have read the DCO document and I hereby sign the DCO.

@drew drew changed the title Windows compilation feat(gateway,cli): windows compilation support Jul 28, 2026
@drew

drew commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

/ok to test d0bcaca

@gburachas

Copy link
Copy Markdown

I have read the DCO document and I hereby sign the DCO.

@araza008
araza008 force-pushed the windows_compilation branch from d0bcaca to 6d0f148 Compare July 29, 2026 14:56
@araza008

Copy link
Copy Markdown
Author

/ok to test 15c622a

@araza008

Copy link
Copy Markdown
Author

/ok to test 7c96e78

@drew

drew commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 7c96e78

@araza008

Copy link
Copy Markdown
Author

/ok to test 923ecf0

@araza008

Copy link
Copy Markdown
Author

/ok to test c1d5e98

@araza008

Copy link
Copy Markdown
Author

/ok to test d1fa290

1 similar comment
@pimlock

pimlock commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

/ok to test d1fa290

Comment thread .agents/skills/build-openshell-mxc-windows/SKILL.md Outdated
@pimlock

This comment was marked as outdated.

@araza008

This comment was marked as outdated.

@araza008

araza008 commented Aug 4, 2026

Copy link
Copy Markdown
Author

/ok to test 60c2340

@araza008
araza008 force-pushed the windows_compilation branch from 602d192 to 97ce1f3 Compare August 4, 2026 18:54
Comment thread crates/openshell-driver-docker/src/lib_entry.rs Outdated
Comment thread crates/openshell-sandbox/Cargo.toml Outdated
Comment thread crates/openshell-prover/src/lib.rs Outdated
Comment thread .github/workflows/windows-msvc.yml Outdated
Comment thread .github/workflows/windows-msvc.yml Outdated
Comment thread .github/workflows/windows-msvc.yml Outdated
Comment thread crates/openshell-sandbox/src/lib_win.rs Outdated
@pimlock

pimlock commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 97ce1f3

@araza008
araza008 force-pushed the windows_compilation branch from 17484be to 833d8eb Compare August 6, 2026 01:08
Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Shailendra Singh <shailendras@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
araza008 and others added 17 commits August 5, 2026 20:16
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
Signed-off-by: Akber Raza <akberr@nvidia.com>
@araza008
araza008 force-pushed the windows_compilation branch from 833d8eb to b2e23e0 Compare August 6, 2026 02:11
@araza008

araza008 commented Aug 6, 2026

Copy link
Copy Markdown
Author

/ok to test b2e23e0

pimlock added 4 commits August 6, 2026 16:34
Signed-off-by: Piotr Mlocek <1116309+pimlock@users.noreply.github.com>
Signed-off-by: Piotr Mlocek <1116309+pimlock@users.noreply.github.com>
Signed-off-by: Piotr Mlocek <1116309+pimlock@users.noreply.github.com>
Signed-off-by: Piotr Mlocek <1116309+pimlock@users.noreply.github.com>
Comment thread crates/openshell-driver-docker/Cargo.toml Outdated
Comment thread crates/openshell-driver-kubernetes/Cargo.toml
Comment thread crates/openshell-sandbox/src/lib.rs
Comment thread crates/openshell-sandbox/src/main.rs
Comment on lines +7 to +22
x64:
runs-on: windows-2025
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- uses: jdx/mise-action@e6a8b3978addb5a52f2b4cd9d91eafa7f0ab959d # v4.2.0
with:
install: false
experimental: true
- uses: dtolnay/rust-toolchain@master
with:
toolchain: "1.95.0"
targets: x86_64-pc-windows-msvc
- run: mise run --skip-tools windows:check:x64
- run: mise run --skip-tools windows:build:x64
- run: mise run --skip-tools windows:test:x64
- run: mise run --skip-tools windows:test:unsupported:x64

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job takes about 80 mins to run (sample run) and it will run on each PR and merge to main. This is too long especially for PRs. We'd need to explore adding cache, so deps are not rebuilt from scratch for each run.

We could make this to be a manual trigger for now and introduce cache and add it to PR runs later.

Signed-off-by: Piotr Mlocek <1116309+pimlock@users.noreply.github.com>
@pimlock

pimlock commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 31c47d2

@pimlock pimlock added test:e2e Requires end-to-end coverage os:windows Bug affects Windows hosts labels Aug 8, 2026
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Label test:e2e applied for 31c47d2. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

Signed-off-by: Piotr Mlocek <1116309+pimlock@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

os:windows Bug affects Windows hosts test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants