docs: verify MLflow delivery and recover existing evaluation exports - #2474
chadvoegele wants to merge 2 commits into
Conversation
Signed-off-by: Chad Voegele <cvoegele@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2474 +/- ##
==========================================
- Coverage 70.91% 70.25% -0.66%
==========================================
Files 600 601 +1
Lines 65987 67132 +1145
==========================================
+ Hits 46794 47166 +372
- Misses 19193 19966 +773
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Chad's Agent — independent reviewReviewed head
Checks: entire five-file diff; surrounding skills, recipes, wrapper and instructions; legacy NEL 0.2.6 exporter/auto-export implementation; nel-next exporter at the wrapper's pinned Limits: no live cluster/MLflow exports or behavioral agent scenarios executed. No checkout changes or fixes made. |
Signed-off-by: Chad Voegele <cvoegele@nvidia.com>
Chad's Agent — review fixesAddressed both findings in 71bdddf:
Checks: changed-file pre-commit passed; agent-definition parity 1 passed; static submission/gate routing, nine scenario definitions, and git diff --check passed. Added/updated existing-config, shortcut, and nel-next evidence scenarios; behavioral agent scenarios and live cluster/MLflow exports were not run. Pushed without rebasing: remote head was unchanged and PR mergeable. No merge performed. |
What does this PR do?
Type of change: documentation.
Chad's Agent: Separate evaluation completion from verified MLflow delivery. Add a ModelOpt-owned gate to verify per-task identity, scores, configuration, and diagnostic artifacts; recover exports from existing results using installed CLI help; avoid duplicate exports; preserve sanitized evidence when delivery is blocked.
Motivation: completed evaluations can lose delivery when their separate CPU export jobs fail to import the export image. This must not trigger another evaluation or a false success report.
Both evaluator definitions return verified URLs and invocation IDs with independent evaluation/export outcomes. Vendored skills and nel-next's explicit push workflow are unchanged.
Usage
Follow
evaluation/references/mlflow-verification.mdafter completed-run validation. No API changes.Testing
uv run --no-project --with pytest pytest -o addopts='' -q plugins/modelopt/skills/day0-release/tests/test_agent_definitions.py— 1 passed (existing timeout-config warning).git diff --check— passed.Before your PR is "Ready for review"
Additional Information
Coordinated scope with the parent-authorization agent (#2473) and truncation-policy agent. This PR does not change acceptance thresholds or submission authorization; export recovery never starts another evaluation. Keep the standalone export paragraph in both evaluator definitions when integrating their handoff edits.