Skip to content

Add ROS 2 Lyrical support - #40

Open
bmchalenv wants to merge 4 commits into
NVIDIA-ISAAC-ROS:mainfrom
bmchalenv:support-lyrical
Open

Add ROS 2 Lyrical support#40
bmchalenv wants to merge 4 commits into
NVIDIA-ISAAC-ROS:mainfrom
bmchalenv:support-lyrical

Conversation

@bmchalenv

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Blake McHale <bmchale@nvidia.com>
Signed-off-by: Blake McHale <bmchale@nvidia.com>
Signed-off-by: Blake McHale <bmchale@nvidia.com>
Signed-off-by: Blake McHale <bmchale@nvidia.com>
@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

Adds ROS 2 Lyrical on Ubuntu Resolute throughout CI, packaging, local test helpers, and compatibility documentation.

  • Adds Lyrical/Resolute entries to source-test and Debian-package matrices.
  • Updates distro validation, Docker image selection, and Python dependency handling.
  • Makes Lyrical/Resolute the default for local build and Docker test scripts.

Confidence Score: 5/5

The PR appears safe to merge, with the Lyrical/Resolute mapping consistently applied across CI and local tooling.

No concrete changed-code failure remains; the new distribution pair is represented consistently in both workflow matrices, validation logic, Docker mapping, and dependency-installation branches.

Important Files Changed

Filename Overview
.github/workflows/debian-packages.yml Adds Lyrical/Resolute to package generation and smoke-test matrices and applies modern pip installation flags.
.github/workflows/ros-tests.yml Adds Lyrical/Resolute source-build and test coverage with matching Python dependency handling.
scripts/build_debian_packages.sh Accepts Lyrical, updates the default platform pair to Lyrical/Resolute, and enables externally managed Python handling.
scripts/docker-test.sh Adds the Lyrical ROS base image mapping and makes it the default local test environment.
README.md Documents Lyrical and Ubuntu 26.04 as supported platforms.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    L[ROS 2 Lyrical] --> U[Ubuntu Resolute]
    U --> T[ROS source-test matrix]
    U --> P[Debian build and smoke-test matrices]
    U --> D[Local Docker test helper]
    U --> B[Local Debian package builder]
Loading

Reviews (1): Last reviewed commit: "Update Lyrical Docker build example" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant