Skip to content

Add clang-tidy correctness CI - #308

Open
scal444 wants to merge 1 commit into
NVIDIA-BioNeMo:mainfrom
scal444:codex/clang-tidy-ci
Open

Add clang-tidy correctness CI#308
scal444 wants to merge 1 commit into
NVIDIA-BioNeMo:mainfrom
scal444:codex/clang-tidy-ci

Conversation

@scal444

@scal444 scal444 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Updates to use clang-tidy 22 which has limited CUDA support.

We're starting with correctness-only items, then will expand with coverage and fixes .

Only true bug fixed in this diff is an unlikely overrun adding 1 to maxBatchSize BEFORE converting to size_t instead of after. The rest are defensive, or needed to get Clang CUDA compiling.

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previous checkout pinning concern is fixed and no actionable new failures were identified.

Summary

  • Adds CUDA compile-database conversion and host-only CUDA analysis.
  • Pins the CI checkout action to a reviewed commit SHA.
  • Fixes size arithmetic so conversion occurs before incrementing maxBatchSize.
  • Applies defensive initialization, explicit raw shared storage, and analyzer-oriented code refinements.

Reviews (2) · Last reviewed commit: "Add clang-tidy correctness CI"

Comment thread .github/workflows/static-analysis.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant