Fix concurrent ETKDG retry dispatch - #299
Merged
scal444 merged 2 commits intoSep 11, 2026
Merged
Conversation
Contributor
|
scal444
force-pushed
the
codex/etkdg-dispatch-retry-fix
branch
from
September 10, 2026 16:38
82bb02b to
5c331d3
Compare
scal444
force-pushed
the
codex/etkdg-dispatch-retry-fix
branch
from
September 10, 2026 20:04
5c331d3 to
5b3cf25
Compare
evasnow1992
reviewed
Sep 10, 2026
evasnow1992
approved these changes
Sep 10, 2026
evasnow1992
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me. One minor comment but not blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ETKDG worker can temporarily run out of dispatchable work while another
worker still has attempts in flight. The first worker currently treats that
empty dispatch as global completion. If any in-flight attempts subsequently
fail, their retries are never scheduled.
Track in-flight attempts in the scheduler and make production dispatch wait
until those attempts are recorded. Retry rounds now advance only after the
current round has completed. Cancellation wakes waiting workers, and exceptions
from dispatch threads are rethrown by
embedMolecules()instead of beingsilently discarded.
The scheduler also returns stable, per-molecule attempt IDs. This lets callers
vary retry initialization independently of thread scheduling and batch order.
Fixes #300