Skip to content

Fix concurrent ETKDG retry dispatch - #299

Merged
scal444 merged 2 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/etkdg-dispatch-retry-fix
Sep 11, 2026
Merged

Fix concurrent ETKDG retry dispatch#299
scal444 merged 2 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/etkdg-dispatch-retry-fix

Conversation

@scal444

@scal444 scal444 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

An ETKDG worker can temporarily run out of dispatchable work while another
worker still has attempts in flight. The first worker currently treats that
empty dispatch as global completion. If any in-flight attempts subsequently
fail, their retries are never scheduled.

Track in-flight attempts in the scheduler and make production dispatch wait
until those attempts are recorded. Retry rounds now advance only after the
current round has completed. Cancellation wakes waiting workers, and exceptions
from dispatch threads are rethrown by embedMolecules() instead of being
silently discarded.

The scheduler also returns stable, per-molecule attempt IDs. This lets callers
vary retry initialization independently of thread scheduling and batch order.

Fixes #300

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness or repository-rule violations identified.

Summary

  • Prevents workers from declaring completion while retry-producing attempts remain in flight.
  • Preserves per-molecule conformer and retry limits under concurrent dispatch.
  • Adds focused tests for retries, stable attempt IDs, cancellation, and blocking dispatch behavior.

Reviews (4) · Last reviewed commit: "Stop ETKDG dispatch scan when batch is f..."

@scal444
scal444 force-pushed the codex/etkdg-dispatch-retry-fix branch from 82bb02b to 5c331d3 Compare September 10, 2026 16:38
@scal444
scal444 requested a review from evasnow1992 September 10, 2026 18:27
@scal444
scal444 force-pushed the codex/etkdg-dispatch-retry-fix branch from 5c331d3 to 5b3cf25 Compare September 10, 2026 20:04
Comment thread src/etkdg_impl.cpp Outdated

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. One minor comment but not blocking.

@scal444
scal444 merged commit 959553c into NVIDIA-BioNeMo:main Sep 11, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ETKDG can exit early on failing molecules without full maxAttempts exercised

2 participants