Skip to content

Enable eigenvalue ETKDG coordinate generation - #292

Open
scal444 wants to merge 7 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/issue288-eigen-coords
Open

Enable eigenvalue ETKDG coordinate generation#292
scal444 wants to merge 7 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/issue288-eigen-coords

Conversation

@scal444

@scal444 scal444 commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Match RDKit eigen initialization and retry behavior, make the batched eigensolver padding- and stream-aware, and enable the default EmbedMolecules path with updated docs and tests.\n\nCloses #288

@scal444
scal444 force-pushed the codex/issue288-eigen-coords branch from 34f74ed to 82adc04 Compare September 10, 2026 13:03
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because no accepted new actionable findings remain.

Summary

  • Adds padded, per-system-dimension-aware eigensolver execution on caller-selected CUDA streams.
  • Implements RDKit-compatible distance sampling, seeding, negative-eigenvalue handling, and retry behavior.
  • Adds the 256-atom eigenvalue initialization limit and updates Python validation, documentation, examples, and tests.
  • Preserves random-coordinate initialization when explicitly requested.

Reviews (10) · Last reviewed commit: "Allow small-system eigen coordinate gene..."

@scal444
scal444 force-pushed the codex/issue288-eigen-coords branch from 82adc04 to 5438598 Compare September 10, 2026 13:48
Comment thread src/forcefields/coord_gen.cu
@scal444
scal444 force-pushed the codex/issue288-eigen-coords branch 2 times, most recently from 3efe828 to 2be4821 Compare September 10, 2026 14:27
@scal444 scal444 changed the title Enable eigenvalue ETKDG coordinate generation [draft] Enable eigenvalue ETKDG coordinate generation Sep 10, 2026
Match RDKit eigen initialization and retry behavior, make the batched eigensolver padding- and stream-aware, and enable the default EmbedMolecules path with updated docs and tests.\n\nCloses NVIDIA-BioNeMo#288
@scal444
scal444 force-pushed the codex/issue288-eigen-coords branch from ef9504a to 6022b4a Compare September 10, 2026 20:04
@scal444 scal444 changed the title [draft] Enable eigenvalue ETKDG coordinate generation Enable eigenvalue ETKDG coordinate generation Sep 11, 2026
@scal444
scal444 requested a review from evasnow1992 September 11, 2026 16:08
Comment thread src/forcefields/coord_gen.cu Outdated

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the comment. Changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants