Enable eigenvalue ETKDG coordinate generation - #292
Open
scal444 wants to merge 7 commits into
Open
Conversation
scal444
force-pushed
the
codex/issue288-eigen-coords
branch
from
September 10, 2026 13:03
34f74ed to
82adc04
Compare
Contributor
|
scal444
force-pushed
the
codex/issue288-eigen-coords
branch
from
September 10, 2026 13:48
82adc04 to
5438598
Compare
scal444
force-pushed
the
codex/issue288-eigen-coords
branch
2 times, most recently
from
September 10, 2026 14:27
3efe828 to
2be4821
Compare
Match RDKit eigen initialization and retry behavior, make the batched eigensolver padding- and stream-aware, and enable the default EmbedMolecules path with updated docs and tests.\n\nCloses NVIDIA-BioNeMo#288
scal444
force-pushed
the
codex/issue288-eigen-coords
branch
from
September 10, 2026 20:04
ef9504a to
6022b4a
Compare
…n-coords # Conflicts: # src/etkdg_impl.cpp # src/etkdg_impl.h # tests/test_etkdg_result_tracker.cpp
evasnow1992
reviewed
Sep 11, 2026
evasnow1992
approved these changes
Sep 11, 2026
evasnow1992
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for addressing the comment. Changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match RDKit eigen initialization and retry behavior, make the batched eigensolver padding- and stream-aware, and enable the default EmbedMolecules path with updated docs and tests.\n\nCloses #288