Review outstanding TODOs

[HarikaBishai]

This issue collects the TODO/FIXME comments in the nsls2api application. Review each item and decide whether to complete it, revise it, or remove it.

Partially Done

• Sort facility operating cycles
  Existing sort logic needs verification and a multi-cycle test.

• Validate beamline names
  Names are uppercased, but invalid input is not rejected.

• Use facility health checks in the current-cycle endpoint
  facility_service.is_healthy() exists but is not used by this endpoint.

• Finalize beamline account endpoint design
  An aggregate endpoint exists; individual account routes are hidden.

Open

• Verify that a facility exists during health checks

• Configure the directory-skeleton asset folder

• Handle commissioning proposals without a beamline

• Publish or retire the department lookup endpoint

• Configure jobs sync-route schema visibility by environment

Completed

• Publish /person/me in OpenAPI
  The endpoint already has include_in_schema=True; remove or update the outdated TODO.

Vendored HTMX, Not Local Application Work

The application loads htmx.min.js; htmx.js is the readable vendored source. These TODOs belong upstream and should only be addressed through an HTMX upgrade.

• Document HTMX public API methods
• Rework HTMX document-fragment handling
• Remove legacy Internet Explorer code
• Rework HTMX SSE/AJAX/WebSocket behavior
• Define HTMX response-header typing

Vendored Font Awesome, Not Local Application Work

• Review Font Awesome icon registration

Do not modify vendored HTMX or Font Awesome files directly; handle them through upstream dependency upgrades.

[HarikaBishai]

Padraic Shafer (@padraic-shafer) Dan Allan (@danielballan) Nathanael (Nate) Maytan (@nmaytan) I’ve listed all the TODO comments currently in nsls2api here so we can review them, identify what should be prioritized, and determine which ones are no longer needed.