fix: Increase memory limit for Node.js in Docker containers to handle… - #132
Merged
Conversation
… large 2D spectra
There was a problem hiding this comment.
Pull request overview
Updates the nmr-cli Docker image runtime settings so Node.js can process large 2D spectra without hitting V8’s default old-space heap cap.
Changes:
- Sets
NODE_OPTIONSin thenmr-cliDockerfile to increase--max-old-space-size(12 GB). - Adds an inline comment explaining why the heap limit is being raised.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hamed-musallam
approved these changes
Aug 13, 2026
NishaSharma14
added a commit
that referenced
this pull request
Aug 13, 2026
* build: update prod build workflow to build image with release tag (#129) * build: update prod build workflow to create and push docker image with release tag * fix: Increase memory limit for Node.js in Docker containers to handle… (#132) * fix: Increase memory limit for Node.js in Docker containers to handle large 2D spectra * max-old-space-size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… large 2D spectra