Skip to content

fix: keep background CI from blocking advisory completion - #114

Merged
rldyourmnd merged 2 commits into
mainfrom
fix/complete-advisory-background-ci-20260908
Sep 8, 2026
Merged

fix: keep background CI from blocking advisory completion#114
rldyourmnd merged 2 commits into
mainfrom
fix/complete-advisory-background-ci-20260908

Conversation

@rldyourmnd

Copy link
Copy Markdown
Contributor

Summary

  • Under the continuous-development profile, gds complete no longer refuses integration solely because declared required lanes lack GitHub execution evidence.
  • Those lanes stay not-proven in the assessment. Failure remains failure. Absent the profile, the existing required-checks-not-proven refusal is unchanged.

Test plan

  • go test ./core/app -run TestUnprovenRequiredChecksBlockOnlyWithoutAdvisoryCI
  • go test ./core/cli -run TestCompleteBlocksUnprovenChecksPRPolicyAndNetworkApply
  • go test ./core/cli -run TestCompleteRequiresExactPlanApprovalAndVerify

rldyourmnd and others added 2 commits September 8, 2026 12:48
Ordinary gds complete under continuous-development still records unproven
required lanes. It does not treat missing GitHub execution evidence as a
merge gate. Absent that profile, the existing not-proven refusal remains.

Signed-off-by: rldyourmnd <danil@nddev.it.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
complete_workflow.go is inside the development source boundary, so the
advisory-completion change must refresh the applied source_tree_digest.

Signed-off-by: rldyourmnd <danil@nddev.it.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@rldyourmnd
rldyourmnd force-pushed the fix/complete-advisory-background-ci-20260908 branch from f441155 to dfbd24c Compare September 8, 2026 07:49
@rldyourmnd
rldyourmnd merged commit 72c9e54 into main Sep 8, 2026
5 checks passed
@rldyourmnd
rldyourmnd deleted the fix/complete-advisory-background-ci-20260908 branch September 8, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant